Minni: Lightweight MapReduce Library

Issue 2: [lib] Build Task for Reducer.cpp

Next issue

Reported by Wolfgang Richter, Jun 16, 2010

Need to fix these compile-time warnings:


Reducer.cpp: In function ‘int deSerialize(FILE*, char*, uint64_t*, 
char**, uint64_t*, char**)’:
Reducer.cpp:95: warning: ignoring return value of ‘size_t 
fread(void*, size_t, size_t, FILE*)’, declared with attribute 
warn_unused_result
Reducer.cpp:97: warning: ignoring return value of ‘size_t 
fread(void*, size_t, size_t, FILE*)’, declared with attribute 
warn_unused_result
Reducer.cpp:101: warning: ignoring return value of ‘size_t 
fread(void*, size_t, size_t, FILE*)’, declared with attribute 
warn_unused_result
Reducer.cpp:103: warning: ignoring return value of ‘size_t 
fread(void*, size_t, size_t, FILE*)’, declared with attribute 
warn_unused_result
Reducer.cpp:107: warning: ignoring return value of ‘size_t 
fread(void*, size_t, size_t, FILE*)’, declared with attribute 
warn_unused_result

Comment 1 by Athula Balachandran, Jun 16, 2010

Fixed the above warnings

Comment 2 by Wolfgang Richter, Jun 16, 2010

Status: Fixed

Comment 3 by Athula Balachandran, Jun 16, 2010

Changing to .patch file

Comment 4 by Wolfgang Richter, Jun 16, 2010

Could we change to return -1 on error instead of exit(1)?

That would maintain consistency with the other feof error cases.
Status: Started

Comment 5 by Athula Balachandran, Jun 16, 2010

Error cases consistent now 

-- replaced exit(1) with return -1
Status: Fixed

Comment 6 by Athula Balachandran, Jun 16, 2010

Forgot to attach patch

Created: 15 years 1 month ago by Wolfgang Richter

Updated: 15 years 1 month ago

Status: Fixed

Owner: Athula Balachandran

Labels:
Type:Enhancement
Priority:Low
Other:Security